chrome/common/extensions/extension_file_util.cc - Issue 1120006: detect preferences errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_file_util.cc

Issue 1120006: detect preferences errors (Closed)

Patch Set: changes from review Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_file_util.cc

diff --git a/chrome/common/extensions/extension_file_util.cc b/chrome/common/extensions/extension_file_util.cc

index 1420b9e3120d380262c4a9e3bf94c3d1f176dab7..6fdccfd80b6f36e8f6e2e9ed946da518d3887f00 100644

--- a/chrome/common/extensions/extension_file_util.cc

+++ b/chrome/common/extensions/extension_file_util.cc

@@ -115,7 +115,7 @@ Extension* LoadExtension(const FilePath& extension_path,

}

JSONFileValueSerializer serializer(manifest_path);

- scoped_ptr<Value> root(serializer.Deserialize(error));

+ scoped_ptr<Value> root(serializer.Deserialize(NULL, error));

if (!root.get()) {

if (error->empty()) {

// If |error| is empty, than the file could not be read.