Issue 11195055: Extensions Docs Server: Fix handling of nodocs in server2

Issue 11195055: Extensions Docs Server: Fix handling of nodocs in server2 (Closed)

Created:
8 years, 2 months ago by cduvall

Modified:
8 years, 1 month ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, Matt Perry, mkearney1, not at google - send to devlin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extensions Docs Server: Fix handling of nodocs in server2 Some nodocs were being left in the documentation by server2. BUG=154387 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164227

Patch Set 1 #

Total comments: 2

Patch Set 2 : increment APIDataSource version #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -4 lines)			Patch
M	chrome/common/extensions/docs/server2/api_data_source.py	View	1	1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/api_data_source_test.py	View		2 chunks	+9 lines, -1 line	0 comments	Download
A	chrome/common/extensions/docs/server2/test_data/test_json/expected_nodoc.json	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/docs/server2/test_data/test_json/nodoc_test.json	View		1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Sorry for high review latency. http://codereview.chromium.org/11195055/diff/1/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): http://codereview.chromium.org/11195055/diff/1/chrome/common/extensions/docs/server2/api_data_source.py#newcode24 chrome/common/extensions/docs/server2/api_data_source.py:24: if item.get('nodoc', False): Weird ...

8 years, 2 months ago (2012-10-24 22:25:01 UTC) #3

cduvall

http://codereview.chromium.org/11195055/diff/1/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): http://codereview.chromium.org/11195055/diff/1/chrome/common/extensions/docs/server2/api_data_source.py#newcode24 chrome/common/extensions/docs/server2/api_data_source.py:24: if item.get('nodoc', False): On 2012/10/24 22:25:02, Aaron Boodman wrote: ...

8 years, 1 month ago (2012-10-26 00:01:46 UTC) #4

I'm sorry, you are totally right.

lgtm

Expand Messages | Collapse Messages