Extensions Docs Server: Fix handling of nodocs in server2

chrome/common/extensions/docs/server2/api_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import json
 import os
 
 from docs_server_utils import GetLinkToRefType
 import compiled_file_system as compiled_fs
 from file_system import FileNotFoundError
 import third_party.json_schema_compiler.json_comment_eater as json_comment_eater
 import third_party.json_schema_compiler.model as model
 import third_party.json_schema_compiler.idl_schema as idl_schema
 import third_party.json_schema_compiler.idl_parser as idl_parser
 
 # Increment this version when there are changes to the data stored in any of
 # the caches used by APIDataSource. This allows the cache to be invalidated
 # without having to flush memcache on the production server.
-_VERSION = 0
+_VERSION = 1
 
 def _RemoveNoDocs(item):
   if type(item) == dict:
     if item.get('nodoc', False):

[Aaron Boodman, 2012/10/24 22:25:02]

Weird to assume that only dictionaries can have 'nodoc'. move this out of the
dict typecheck/

[cduvall, 2012/10/26 00:01:47]

I don't see how a type besides a dictionary could have 'nodoc'. I think 'nodoc':
true can only be specified as an item in a dictionary. Can you give an example
of how 'nodoc' could be in something other than a dict?

       return True
+    to_remove = []
     for key, value in item.items():
       if _RemoveNoDocs(value):
-        del item[key]
+        to_remove.append(key)
+    for k in to_remove:
+      del item[k]
   elif type(item) == list:
+    to_remove = []
     for i in item:
       if _RemoveNoDocs(i):
-        item.remove(i)
+        to_remove.append(i)
+    for i in to_remove:
+      item.remove(i)
   return False
 
 def _CreateId(node, prefix):
   if node.parent is not None and not isinstance(node.parent, model.Namespace):
     return '-'.join([prefix, node.parent.simple_name, node.simple_name])
   return '-'.join([prefix, node.simple_name])
 
 def _FormatValue(value):
   """Inserts commas every three digits for integer values. It is magic.
   """
@@ skipping 279 matching lines @@
 
   def get(self, key):
     path, ext = os.path.splitext(key)
     unix_name = model.UnixName(path)
     idl_names = self._idl_names_cache.GetFromFileListing(self._base_path)
     cache, ext = ((self._idl_cache, '.idl') if (unix_name in idl_names) else
                   (self._json_cache, '.json'))
     return self._GenerateHandlebarContext(
         cache.GetFromFile('%s/%s%s' % (self._base_path, unix_name, ext)),
         path)