[Android] Upstream external_protocol_dialog_android.cc

chrome/browser/android/tab_base_android_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_TAB_BASE_ANDROID_IMPL_H_
 #define CHROME_BROWSER_ANDROID_TAB_BASE_ANDROID_IMPL_H_
 
 #include <jni.h>
 
 #include "base/compiler_specific.h"
@@ skipping 42 matching lines @@
       const content::ContextMenuParams& params,
       const base::Callback<void(int)>& callback) OVERRIDE;
 
   virtual void AddShortcutToBookmark(const GURL& url,
                                      const string16& title,
                                      const SkBitmap& skbitmap,
                                      int r_value,
                                      int g_value,
                                      int b_value) OVERRIDE;
 
+  // Called when the common ExternalProtocolHandler wants to
+  // run the external protocol dialog.

[Ted C, 2012/10/16 23:25:10]

also, I would leave this comment out of the impl.h as that is a common construct
for OVERRIDE methods

[newt (away), 2012/10/16 23:29:50]

Done.

+  virtual void RunExternalProtocolDialog(const GURL& url) OVERRIDE;
+
   // Register the Tab's native methods through JNI.
   static bool RegisterTabBaseAndroidImpl(JNIEnv* env);
 
   // --------------------------------------------------------------------------
   // Methods called from Java via JNI
   // --------------------------------------------------------------------------
   void InitWebContentsDelegate(JNIEnv* env,
                                jobject obj,
                                jobject web_contents_delegate);
 
   base::android::ScopedJavaLocalRef<jstring> FixupUrl(JNIEnv* env,
                                                       jobject obj,
                                                       jstring url);
 
  protected:
   virtual ~TabBaseAndroidImpl();
 
  private:
   scoped_ptr<content::WebContents> web_contents_;
   scoped_ptr<WebKit::WebLayer> tab_layer_;
   scoped_ptr<chrome::android::ChromeWebContentsDelegateAndroid>
           web_contents_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(TabBaseAndroidImpl);
 };
 
 #endif  // CHROME_BROWSER_ANDROID_TAB_BASE_ANDROID_IMPL_H_