Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 11175077: Fix the low battery notification string from mins -> minutes. (Closed)

Created:
8 years, 2 months ago by jennyz
Modified:
8 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix the low battery notification string from mins -> minutes. The previous fix from: http://src.chromium.org/viewvc/chrome?view=rev&revision=153905 depends on icu formatting function to get the localized time remaining strings. However, the string from icu formatter does not provide the format we want, it uses "mins" instead of "minutes". Hence, revert to use the old ash_string.grd to localize the minute string we prefer, and add a singular minute string. BUG=157169

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M ash/ash_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/shell_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/system/power/power_status_view.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
jennyz
8 years, 2 months ago (2012-10-23 23:44:03 UTC) #1
sadrul
http://codereview.chromium.org/11175077/diff/1/chrome/browser/ui/ash/chrome_shell_delegate.cc File chrome/browser/ui/ash/chrome_shell_delegate.cc (left): http://codereview.chromium.org/11175077/diff/1/chrome/browser/ui/ash/chrome_shell_delegate.cc#oldcode448 chrome/browser/ui/ash/chrome_shell_delegate.cc:448: return TimeFormat::TimeRemaining(delta); Seeing how complicated the code in TimeFormat ...
8 years, 2 months ago (2012-10-24 03:49:06 UTC) #2
jennyz
8 years, 2 months ago (2012-10-24 18:42:40 UTC) #3
http://codereview.chromium.org/11175077/diff/1/chrome/browser/ui/ash/chrome_s...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (left):

http://codereview.chromium.org/11175077/diff/1/chrome/browser/ui/ash/chrome_s...
chrome/browser/ui/ash/chrome_shell_delegate.cc:448: return
TimeFormat::TimeRemaining(delta);
On 2012/10/24 03:49:06, sadrul wrote:
> Seeing how complicated the code in TimeFormat is, does it make sense to
> introduce TimeRemainingLong instead (I see that there is a TimeRemainingShort)
> and keep using the code in TimeFormat?
I am discussing the TimeFormat::TimeRemainingLong support with jshin@ who is the
author for TimeFormat code. He is in conference today and will back to me
probably tomorrow.

Powered by Google App Engine
This is Rietveld 408576698