Replace AudioManager::Init() with InitializeOnAudioThread().

Replace AudioManager::Init() with InitializeOnAudioThread().

Collapses the Init() method into the constructor since it was always
called immediately anyways and provides a more useful method for
performing initialization on the audio thread.

BUG=153056
TEST=media_unittests continue to work and pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163720

[DaleCurtis, 2012-10-23 20:04:37]

Outcome of our discussion from http://codereview.chromium.org/11233023/

[scherkus (not reviewing), 2012-10-23 20:54:45]

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_manager_base.h
File media/audio/audio_manager_base.h (right):

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_manager_bas...
media/audio/audio_manager_base.h:117: void ShutdownOnAudioThread();
confusing alert: this is similarly named BUT is not intended to be overridden

it looks like this can be private

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_output_prox...
File media/audio/audio_output_proxy_unittest.cc (right):

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_output_prox...
media/audio/audio_output_proxy_unittest.cc:100: Shutdown();
does this fix anything?

https://codereview.chromium.org/11175066/diff/1/media/audio/openbsd/audio_man...
File media/audio/openbsd/audio_manager_openbsd.cc (left):

https://codereview.chromium.org/11175066/diff/1/media/audio/openbsd/audio_man...
media/audio/openbsd/audio_manager_openbsd.cc:55: AudioManagerBase::Init();
lol

[DaleCurtis, 2012-10-23 21:05:52]

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_manager_base.h
File media/audio/audio_manager_base.h (right):

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_manager_bas...
media/audio/audio_manager_base.h:117: void ShutdownOnAudioThread();
On 2012/10/23 20:54:45, scherkus wrote:
> confusing alert: this is similarly named BUT is not intended to be overridden
> 
> it looks like this can be private

Done.

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_output_prox...
File media/audio/audio_output_proxy_unittest.cc (right):

https://codereview.chromium.org/11175066/diff/1/media/audio/audio_output_prox...
media/audio/audio_output_proxy_unittest.cc:100: Shutdown();
On 2012/10/23 20:54:45, scherkus wrote:
> does this fix anything?

Yes, otherwise the audio_thread_ will still be alive when AudioManagerBase
destructs and throw a CHECK failure(). AMB expects all implementations to
explicitly call Shutdown() prior to destruction.

My guess is it's a means for ensuring implementations take care of their own
cleanup first? Seems silly to me and should just be called from AMB's
destructor... I can clean that up in this CL too if you like.

[scherkus (not reviewing), 2012-10-23 21:08:40]

lgtm

most of AudioManager + friends are in dire need of flamethrowing, however let's
get this in as is for now

[commit-bot: I haz the power, 2012-10-23 21:20:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/11175066/12003

[commit-bot: I haz the power, 2012-10-23 23:20:57]

Change committed as 163720