Implement SkImageFilter support in the compositor.

cc/render_pass.h

Index: cc/render_pass.h
diff --git a/cc/render_pass.h b/cc/render_pass.h
index 5289c2bc64dddb3f37e747f76fcc70164fedcba1..744cb85f4a95b909df8275d472c0d1cc3aa0257a 100644
--- a/cc/render_pass.h
+++ b/cc/render_pass.h
@@ -18,6 +18,8 @@
 #include <public/WebTransformationMatrix.h>
 #include <vector>
 
+class SkImageFilter;
+
 namespace cc {
 
 class CCLayerImpl;
@@ -91,6 +93,9 @@ public:
     const WebKit::WebFilterOperations& backgroundFilters() const { return m_backgroundFilters; }
     void setBackgroundFilters(const WebKit::WebFilterOperations& filters) { m_backgroundFilters = filters; }
 
+    SkImageFilter* filter() const { return m_filter; }
+    void setFilter(SkImageFilter* filter);
+
     bool hasTransparentBackground() const { return m_hasTransparentBackground; }
     void setHasTransparentBackground(bool transparent) { m_hasTransparentBackground = transparent; }
 
@@ -109,6 +114,7 @@ protected:
     bool m_hasOcclusionFromOutsideTargetSurface;
     WebKit::WebFilterOperations m_filters;
     WebKit::WebFilterOperations m_backgroundFilters;
+    SkImageFilter* m_filter;

[danakj, 2012/10/22 18:00:43]

This data type is passed over IPC, we can't add pointers here.

[Stephen White, 2012/10/22 18:51:00]

I understand that this is only a problem for the ubercompositor?  Longer-term,
the plan is to use Skia's serialization infrastructure:  SkImageFilter can
already be flattened via SkFlattenable, so it would just be a matter of writing
that over IPC.  I've added this as a work item on the design doc.

It's ok if the SkImageFilter doesn't work in the ubercompositor for now.  Will
the code as-is cause problems (eg., make ubercomp crash)?

[danakj, 2012/10/22 18:56:02]

Ok. We can serialize this as a 0 until then.

 
     DISALLOW_COPY_AND_ASSIGN(CCRenderPass);
 };