Implement SkImageFilter support in the compositor.

cc/render_pass.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CCRenderPass_h
 #define CCRenderPass_h
 
 #include "CCDrawQuad.h"
 #include "FloatRect.h"
 #include "base/basictypes.h"
 #include "cc/hash_pair.h"
 #include "cc/scoped_ptr_hash_map.h"
 #include "cc/scoped_ptr_vector.h"
 #include "cc/shared_quad_state.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/rect_f.h"
 #include <public/WebFilterOperations.h>
 #include <public/WebTransformationMatrix.h>
 #include <vector>
 
+class SkImageFilter;
+
 namespace cc {
 
 class CCLayerImpl;
 template<typename LayerType, typename SurfaceType>
 class CCOcclusionTrackerBase;
 class CCRenderSurface;
 
 struct CCAppendQuadsData;
 
 typedef CCOcclusionTrackerBase<CCLayerImpl, CCRenderSurface> CCOcclusionTrackerImpl;
@@ skipping 53 matching lines @@
 
     gfx::RectF damageRect() const { return m_damageRect; }
     void setDamageRect(gfx::RectF rect) { m_damageRect = rect; }
 
     const WebKit::WebFilterOperations& filters() const { return m_filters; }
     void setFilters(const WebKit::WebFilterOperations& filters) { m_filters = filters; }
 
     const WebKit::WebFilterOperations& backgroundFilters() const { return m_backgroundFilters; }
     void setBackgroundFilters(const WebKit::WebFilterOperations& filters) { m_backgroundFilters = filters; }
 
+    SkImageFilter* filter() const { return m_filter; }
+    void setFilter(SkImageFilter* filter);
+
     bool hasTransparentBackground() const { return m_hasTransparentBackground; }
     void setHasTransparentBackground(bool transparent) { m_hasTransparentBackground = transparent; }
 
     bool hasOcclusionFromOutsideTargetSurface() const { return m_hasOcclusionFromOutsideTargetSurface; }
     void setHasOcclusionFromOutsideTargetSurface(bool hasOcclusionFromOutsideTargetSurface) { m_hasOcclusionFromOutsideTargetSurface = hasOcclusionFromOutsideTargetSurface; }
 protected:
     CCRenderPass(Id, gfx::Rect outputRect, const WebKit::WebTransformationMatrix& transformToRootTarget);
 
     Id m_id;
     CCQuadList m_quadList;
     CCSharedQuadStateList m_sharedQuadStateList;
     WebKit::WebTransformationMatrix m_transformToRootTarget;
     gfx::Rect m_outputRect;
     gfx::RectF m_damageRect;
     bool m_hasTransparentBackground;
     bool m_hasOcclusionFromOutsideTargetSurface;
     WebKit::WebFilterOperations m_filters;
     WebKit::WebFilterOperations m_backgroundFilters;
+    SkImageFilter* m_filter;

[danakj, 2012/10/22 18:00:43]

This data type is passed over IPC, we can't add pointers here.

[Stephen White, 2012/10/22 18:51:00]

I understand that this is only a problem for the ubercompositor?  Longer-term,
the plan is to use Skia's serialization infrastructure:  SkImageFilter can
already be flattened via SkFlattenable, so it would just be a matter of writing
that over IPC.  I've added this as a work item on the design doc.

It's ok if the SkImageFilter doesn't work in the ubercompositor for now.  Will
the code as-is cause problems (eg., make ubercomp crash)?

[danakj, 2012/10/22 18:56:02]

Ok. We can serialize this as a 0 until then.

 
     DISALLOW_COPY_AND_ASSIGN(CCRenderPass);
 };
 
 } // namespace cc
 
 namespace BASE_HASH_NAMESPACE {
 #if defined(COMPILER_MSVC)
 template<>
 inline size_t hash_value<cc::CCRenderPass::Id>(const cc::CCRenderPass::Id& key) {
@@ skipping 10 matching lines @@
 #error define a hash function for your compiler
 #endif // COMPILER
 }
 
 namespace cc {
 typedef std::vector<CCRenderPass*> CCRenderPassList;
 typedef ScopedPtrHashMap<CCRenderPass::Id, CCRenderPass> CCRenderPassIdHashMap;
 } // namespace cc
 
 #endif