Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 11152002: Add support for messages.json format used to localize Chrome extensions. (Closed)

Created:
8 years, 2 months ago by Sergey Ulanov
Modified:
8 years, 2 months ago
Reviewers:
Jamie, Jói
CC:
grit-developer_googlegroups.com
Base URL:
http://git.chromium.org/external/grit-i18n.git@master
Visibility:
Public.

Description

Add support for messages.json format used to localize Chrome extensions. Chrome uses JSON format for extension and webapps localization. This change adds new output format chrome_messages_json. It will be used to generate resrouces for Chrome Remote Desktop webapp. Committed: https://code.google.com/p/grit-i18n/source/detail?r=77

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -13 lines) Patch
A grit/format/chrome_messages_json.py View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A + grit/format/chrome_messages_json_unittest.py View 1 2 3 6 chunks +36 lines, -12 lines 0 comments Download
M grit/format/js_map_format.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M grit/format/js_map_format_unittest.py View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M grit/node/empty.py View 1 chunk +3 lines, -0 lines 0 comments Download
M grit/test_suite_all.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M grit/tool/build.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
8 years, 2 months ago (2012-10-13 21:42:59 UTC) #1
Jói
Thanks Sergey. I'd like to see a small unit test for this new formatter. Also, ...
8 years, 2 months ago (2012-10-15 10:31:06 UTC) #2
Sergey Ulanov
Added unittest and fixed issue with backslash formatting. http://codereview.chromium.org/11152002/diff/5001/grit/format/chrome_messages_json.py File grit/format/chrome_messages_json.py (right): http://codereview.chromium.org/11152002/diff/5001/grit/format/chrome_messages_json.py#newcode29 grit/format/chrome_messages_json.py:29: loc_message ...
8 years, 2 months ago (2012-10-16 00:50:24 UTC) #3
Jói
8 years, 2 months ago (2012-10-16 10:24:21 UTC) #4
LGTM

I've added you (sergeyu@chromium.org) as a committer, so you should be able to
commit this yourself.  Let me know if you need help.

Cheers,
Jói

Powered by Google App Engine
This is Rietveld 408576698