grit/format/js_map_format.py - Issue 11152002: Add support for messages.json format used to localize Chrome extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/js_map_format.py

Issue 11152002: Add support for messages.json format used to localize Chrome extensions. (Closed) Base URL: http://git.chromium.org/external/grit-i18n.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: grit/format/js_map_format.py

diff --git a/grit/format/js_map_format.py b/grit/format/js_map_format.py

index 044dcd1eb3c718cb9fc708473a7652d1da84b663..64e0466f4fa1d4b73bfa72d15becccfb9322ea70 100644

--- a/grit/format/js_map_format.py

+++ b/grit/format/js_map_format.py

@@ -43,10 +43,12 @@ class Message(interface.ItemFormatter):

# Remove position numbers from placeholders.

en_message = re.sub(r'%\d\$([a-z])', r'%\1', en_message)

# Escape double quotes.

+ en_message = re.sub(r'\\', r'\\\\', en_message)

en_message = re.sub(r'"', r'\"', en_message)

loc_message = item.ws_at_start + item.Translate(lang) + item.ws_at_end

# Escape double quotes.

+ loc_message = re.sub(r'\\', r'\\\\', loc_message)

loc_message = re.sub(r'"', r'\"', loc_message)

return '\nlocalizedStrings["%s"] = "%s";' % (en_message, loc_message)

« no previous file with comments | « grit/format/chrome_messages_json_unittest.py ('k') | grit/format/js_map_format_unittest.py » ('j') | no next file with comments »