Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/extensions/web_view_browsertest.cc

Issue 11147026: Initial refactor to get profiles to propagate storage partition details. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Android's BrowserContext. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/web_view_browsertest.cc
diff --git a/chrome/browser/extensions/web_view_browsertest.cc b/chrome/browser/extensions/web_view_browsertest.cc
index 2849cf459cb8c85d61829c686f97156c5f9713bb..320ce3a509100a8f7a6ca6031fc19c8a4f6cd626 100644
--- a/chrome/browser/extensions/web_view_browsertest.cc
+++ b/chrome/browser/extensions/web_view_browsertest.cc
@@ -100,15 +100,17 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Isolation) {
&cookie_size, &cookie_value);
EXPECT_EQ("testCookie=1", cookie_value);
- // Now, test the browser tags to ensure we have properly set the cookie and
- // we have only one per browser tag and they are not the same.
+ // The default behavior is to combine browser tags with no explicit partition
Charlie Reis 2012/10/30 17:47:48 nit: webview tags :) Can you also add bug 138296
nasko 2012/10/30 19:55:25 Done.
+ // declaration into the same in-memory partition. Test the browser tags to
+ // ensure we have properly set the cookies and we have both cookies in both
+ // browser tags.
automation_util::GetCookies(GURL("http://localhost"),
source1->GetWebContents(),
&cookie_size, &cookie_value);
- EXPECT_EQ("guest1=true", cookie_value);
+ EXPECT_EQ("guest1=true; guest2=true", cookie_value);
automation_util::GetCookies(GURL("http://localhost"),
source2->GetWebContents(),
&cookie_size, &cookie_value);
- EXPECT_EQ("guest2=true", cookie_value);
+ EXPECT_EQ("guest1=true; guest2=true", cookie_value);
}

Powered by Google App Engine
This is Rietveld 408576698