Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/extensions/data_deleter.cc

Issue 11147026: Initial refactor to get profiles to propagate storage partition details. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing Android's BrowserContext. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/data_deleter.cc
diff --git a/chrome/browser/extensions/data_deleter.cc b/chrome/browser/extensions/data_deleter.cc
index 15243c0b6746b5a24c2193f689928ebe59dd6d20..99280cdf96976ea1aeeb2c267b8d43bf68d13e32 100644
--- a/chrome/browser/extensions/data_deleter.cc
+++ b/chrome/browser/extensions/data_deleter.cc
@@ -14,6 +14,8 @@
#include "chrome/common/url_constants.h"
#include "content/public/browser/dom_storage_context.h"
#include "content/public/browser/indexed_db_context.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/site_instance.h"
#include "content/public/browser/storage_partition.h"
#include "content/public/common/content_constants.h"
#include "net/base/completion_callback.h"
@@ -92,11 +94,13 @@ DataDeleter::DataDeleter(
if (storage_origin.SchemeIs(chrome::kExtensionScheme)) {
extension_request_context_ = profile->GetRequestContextForExtensions();
} else if (is_storage_isolated) {
- extension_request_context_ =
- profile->GetRequestContextForStoragePartition(extension_id);
- isolated_app_path_ =
- profile->GetPath().Append(
- content::StoragePartition::GetPartitionPath(extension_id));
+ const GURL& url = Extension::GetBaseURLFromExtensionId(extension_id);
+ content::StoragePartition* storage_partition =
+ BrowserContext::GetStoragePartitionForSite(profile, url);
+ // TODO(ajwong): Cookies are not properly isolated for
+ // chrome-extension:// scheme. See bug http://crbug.com/158386.
+ extension_request_context_ = storage_partition->GetURLRequestContext();
+ isolated_app_path_ = storage_partition->GetPath();
} else {
extension_request_context_ = profile->GetRequestContext();
}

Powered by Google App Engine
This is Rietveld 408576698