DumpRenderTree should use fake strings for page popup UI so we can test localization in layout test…

DumpRenderTree should use fake strings for page popup UI so we can test localization in layout tests.


BUG=155257
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162114

[tkent, 2012-10-15 09:24:21]

https://codereview.chromium.org/11143012/diff/1/webkit/support/test_webkit_pl...
File webkit/support/test_webkit_platform_support.cc (right):

https://codereview.chromium.org/11143012/diff/1/webkit/support/test_webkit_pl...
webkit/support/test_webkit_platform_support.cc:296: return
ASCIIToUTF16("OtherDateLabel");
The string should have form with which we can distinguish it from normal text
easily.  e.g. ${OtherDataLabel}  <<OtherDataLaebl>> l10n-OtherDataLabel

[tkent+u2u_google.com, 2012-10-16 06:47:03]

LGTM

[commit-bot: I haz the power, 2012-10-16 07:08:04]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2012-10-16 07:09:14]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tkent, 2012-10-16 07:09:29]

LGTM

[commit-bot: I haz the power, 2012-10-16 07:09:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/11143012/3

[commit-bot: I haz the power, 2012-10-16 09:58:08]

Change committed as 162114