DumpRenderTree should use fake strings for page popup UI so we can test localization in layout test…

webkit/support/test_webkit_platform_support.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/support/test_webkit_platform_support.h"
 
 #include "base/file_util.h"
 #include "base/metrics/stats_counters.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 249 matching lines @@
         "\x02\x3a\x91\xeb\xa5\x00\x00\x00\x00\x49\x45\x4e\x44\xae\x42\x60"
         "\x82";
     return WebKit::WebData(red_square, arraysize(red_square));
   }
   return webkit_glue::WebKitPlatformSupportImpl::loadResource(name);
 }
 
 WebKit::WebString TestWebKitPlatformSupport::queryLocalizedString(
     WebKit::WebLocalizedString::Name name) {
   // Returns messages same as WebKit's in DRT.
-  // We use different strings for form validation messages.
+  // We use different strings for form validation messages and page popup UI
+  // strings.
   switch (name) {
     case WebKit::WebLocalizedString::ValidationValueMissing:
     case WebKit::WebLocalizedString::ValidationValueMissingForCheckbox:
     case WebKit::WebLocalizedString::ValidationValueMissingForFile:
     case WebKit::WebLocalizedString::ValidationValueMissingForMultipleFile:
     case WebKit::WebLocalizedString::ValidationValueMissingForRadio:
     case WebKit::WebLocalizedString::ValidationValueMissingForSelect:
       return ASCIIToUTF16("value missing");
     case WebKit::WebLocalizedString::ValidationTypeMismatch:
     case WebKit::WebLocalizedString::ValidationTypeMismatchForEmail:
     case WebKit::WebLocalizedString::ValidationTypeMismatchForMultipleEmail:
     case WebKit::WebLocalizedString::ValidationTypeMismatchForURL:
       return ASCIIToUTF16("type mismatch");
     case WebKit::WebLocalizedString::ValidationPatternMismatch:
       return ASCIIToUTF16("pattern mismatch");
     case WebKit::WebLocalizedString::ValidationTooLong:
       return ASCIIToUTF16("too long");
     case WebKit::WebLocalizedString::ValidationRangeUnderflow:
       return ASCIIToUTF16("range underflow");
     case WebKit::WebLocalizedString::ValidationRangeOverflow:
       return ASCIIToUTF16("range overflow");
     case WebKit::WebLocalizedString::ValidationStepMismatch:
       return ASCIIToUTF16("step mismatch");
+    case WebKit::WebLocalizedString::OtherDateLabel:
+      return ASCIIToUTF16("OtherDateLabel");

[tkent, 2012/10/15 09:24:21]

The string should have form with which we can distinguish it from normal text
easily.  e.g. ${OtherDataLabel}  <<OtherDataLaebl>> l10n-OtherDataLabel

+    case WebKit::WebLocalizedString::OtherMonthLabel:
+      return ASCIIToUTF16("OtherMonthLabel");
+    case WebKit::WebLocalizedString::OtherTimeLabel:
+      return ASCIIToUTF16("OtherTimeLabel");
+    case WebKit::WebLocalizedString::OtherWeekLabel:
+      return ASCIIToUTF16("OtherWeekLabel");
+    case WebKit::WebLocalizedString::CalendarClear:
+      return ASCIIToUTF16("CalendarClear");
+    case WebKit::WebLocalizedString::CalendarToday:
+      return ASCIIToUTF16("CalendarToday");
     default:
       return WebKitPlatformSupportImpl::queryLocalizedString(name);
   }
 }
 
 WebKit::WebString TestWebKitPlatformSupport::queryLocalizedString(
     WebKit::WebLocalizedString::Name name, const WebKit::WebString& value) {
   if (name == WebKit::WebLocalizedString::ValidationRangeUnderflow)
     return ASCIIToUTF16("range underflow");
   if (name == WebKit::WebLocalizedString::ValidationRangeOverflow)
@@ skipping 264 matching lines @@
   // Retrieve the last position where we can insert a hyphen before the given
   // index.
   if (before_index >= 2) {
     for (size_t index = before_index - 2; index > 0; --index) {
       if (hyphens[index] & 1)
         return index + 1;
     }
   }
   return 0;
 }