src/ia32/macro-assembler-ia32.h - Issue 1114001: Refactoring of RegExp interface to better support calling several times in a row.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.h

Issue 1114001: Refactoring of RegExp interface to better support calling several times in a row. (Closed)

Patch Set: Fix type that snuck into the commit. Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.h

diff --git a/src/ia32/macro-assembler-ia32.h b/src/ia32/macro-assembler-ia32.h

index 99b1568b6fea182b9931e935d4b9f6b4ea7990c9..f67693984bfc1a4e111319c2cf219c2150d8c4e5 100644

--- a/src/ia32/macro-assembler-ia32.h

+++ b/src/ia32/macro-assembler-ia32.h

@@ -182,7 +182,8 @@ class MacroAssembler: public Assembler {

// Smi tagging support.

void SmiTag(Register reg) {

ASSERT(kSmiTag == 0);

- shl(reg, kSmiTagSize);

+ ASSERT(kSmiTagSize == 1);

+ add(reg, Operand(reg));

}

void SmiUntag(Register reg) {

sar(reg, kSmiTagSize);