Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/ia32/codegen-ia32.cc

Issue 1114001: Refactoring of RegExp interface to better support calling several times in a row. (Closed)
Patch Set: Fix type that snuck into the commit. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/arm/regexp-macro-assembler-arm.cc ('K') | « src/arm/regexp-macro-assembler-arm.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | src/jsregexp.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/codegen-ia32.cc
diff --git a/src/ia32/codegen-ia32.cc b/src/ia32/codegen-ia32.cc
index 08ae99668087de7464011fd7132784f1d3e88bf6..eaf3460179fc008f94ae32a99af6050b5bb4349e 100644
--- a/src/ia32/codegen-ia32.cc
+++ b/src/ia32/codegen-ia32.cc
@@ -10551,13 +10551,7 @@ void RegExpExecStub::Generate(MacroAssembler* masm) {
__ mov(edi, Operand(ecx, edx, times_int_size, 0));
Søren Thygesen Gjesse 2010/03/18 13:54:50 Drive by - you should probably remove the comment
Lasse Reichstein 2010/03/19 11:25:42 Done.
// Perform explicit shift
ASSERT_EQ(0, kSmiTag);
- __ shl(edi, kSmiTagSize);
- // Add previous index (from its stack slot) if value is not negative.
- Label capture_negative;
- // Carry flag set by shift above.
- __ j(negative, &capture_negative, not_taken);
- __ add(edi, Operand(eax)); // Add previous index (adding smi to smi).
- __ bind(&capture_negative);
+ __ SmiTag(edi);
// Store the smi value in the last match info.
__ mov(FieldOperand(ebx,
edx,
« src/arm/regexp-macro-assembler-arm.cc ('K') | « src/arm/regexp-macro-assembler-arm.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | src/jsregexp.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698