Make show_dialog_callback optional in ExtensionInstallPrompt

Make show_dialog_callback optional in ExtensionInstallPrompt

The code is more complex than it has to be. Making show_dialog_callback optional should make it easier to understand.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161744

[Matt Perry, 2012-10-12 19:38:00]

LGTM, thanks!

[commit-bot: I haz the power, 2012-10-12 19:39:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11131002/1

[sail, 2012-10-12 19:41:57]

On 2012/10/12 19:38:00, Matt Perry wrote:
> LGTM, thanks!

Thanks for the review. 
Aaron and I went back and fort on this. He didn't want callers to do this:
  ConfirmWebstoreInstall(..., ExtensionInstallPrompt::ShowDialogCallback())
because it was hard to read. I fixed this by making the parameter non optional.

With this change the parameter is optional again but callers don't pass
ExtensionInstallPrompt::ShowDialogCallback() explicitly so I think it's ok.

Here's the original conversation:
http://codereview.chromium.org/11087071/diff/4016/chrome/browser/extensions/a...

[Aaron Boodman, 2012-10-12 21:09:01]

lgtm

[commit-bot: I haz the power, 2012-10-13 03:11:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-13 05:51:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11131002/1

[commit-bot: I haz the power, 2012-10-13 06:59:46]

Change committed as 161744