Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112004: Merge 41876 - Revert r41803 and r41799... (Closed)

Created:
10 years, 9 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 41876 - Revert r41803 and r41799 BUG=38414 TEST=none TBR=jam Review URL: http://codereview.chromium.org/1039006 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -148 lines) Patch
M chrome/browser/chromeos/app_launcher.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/chromeos/app_launcher.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/cocoa/notifications/balloon_view_host_mac.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/gtk/notifications/balloon_view_host_gtk.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/gtk/tab_contents_drag_source.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/gtk/tab_contents_drag_source.cc View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/views/notifications/balloon_view_host.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_gtk.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/renderer/render_view.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/renderer/render_view.cc View 3 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
10 years, 9 months ago (2010-03-18 23:47:05 UTC) #1
Evan Stade
10 years, 9 months ago (2010-03-19 00:09:10 UTC) #2 
lgtm

-- Evan Stade



On Thu, Mar 18, 2010 at 4:47 PM,  <laforge@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Description:
> Merge 41876 - Revert r41803 and r41799
>
> BUG=38414
> TEST=none
> TBR=jam
>
> Review URL: http://codereview.chromium.org/1039006
>
> TBR=estade@chromium.org
>
> Please review this at http://codereview.chromium.org/1112004
>
> SVN Base: svn://svn.chromium.org/chrome/branches/356/src/
>
> Affected files:
>  M     chrome/browser/chromeos/app_launcher.h
>  M     chrome/browser/chromeos/app_launcher.cc
>  M     chrome/browser/cocoa/notifications/balloon_view_host_mac.h
>  M     chrome/browser/extensions/extension_host.h
>  M     chrome/browser/extensions/extension_host.cc
>  M     chrome/browser/gtk/notifications/balloon_view_host_gtk.h
>  M     chrome/browser/gtk/tab_contents_drag_source.h
>  M     chrome/browser/gtk/tab_contents_drag_source.cc
>  M     chrome/browser/renderer_host/render_view_host.h
>  M     chrome/browser/renderer_host/render_view_host.cc
>  M     chrome/browser/renderer_host/render_view_host_delegate.h
>  M     chrome/browser/tab_contents/interstitial_page.cc
>  M     chrome/browser/tab_contents/tab_contents_view_gtk.h
>  M     chrome/browser/tab_contents/tab_contents_view_gtk.cc
>  M     chrome/browser/tab_contents/tab_contents_view_mac.h
>  M     chrome/browser/tab_contents/tab_contents_view_mac.mm
>  M     chrome/browser/views/notifications/balloon_view_host.h
>  M     chrome/browser/views/tab_contents/tab_contents_view_gtk.h
>  M     chrome/browser/views/tab_contents/tab_contents_view_gtk.cc
>  M     chrome/browser/views/tab_contents/tab_contents_view_win.h
>  M     chrome/browser/views/tab_contents/tab_contents_view_win.cc
>  M     chrome/common/render_messages_internal.h
>  M     chrome/renderer/render_view.h
>  M     chrome/renderer/render_view.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698