Include sstream instead of iostream to avoid the additional IO static initializer

Include sstream instead of iostream to avoid the additional IO static
initializer.

BUG=155472
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161756

[Hongbo Min, 2012-10-12 08:01:15]

benwells,

here I included sstream for isstringstream, which is also already used in other
files.

[benwells, 2012-10-12 08:04:52]

lgtm

adding falken@ as well, who reverted the change using iostream. Please wait for
falken@'s lgtm before landing.

[Hongbo Min, 2012-10-12 14:58:13]

On 2012/10/12 08:04:52, benwells wrote:
> lgtm
> 
> adding falken@ as well, who reverted the change using iostream. Please wait
for
> falken@'s lgtm before landing.

OK. Thanks.

[falken, 2012-10-13 02:09:23]

lgtm

By the way, you can use "tools/linux/dump-static-initializers.py
out/Release/chrome" to see the static initializers on Linux. I tested with the
patch that was reverted and it looks like sstream instead of iostream fixes the
static initializer problem.

[Hongbo Min, 2012-10-13 04:37:32]

On 2012/10/13 02:09:23, falken wrote:
> lgtm
> 
> By the way, you can use "tools/linux/dump-static-initializers.py
> out/Release/chrome" to see the static initializers on Linux. I tested with the
> patch that was reverted and it looks like sstream instead of iostream fixes
the
> static initializer problem.

Thanks. I have tested with "tools/linux/dump-static-initializers.py
out/Release/chrome".

[commit-bot: I haz the power, 2012-10-13 04:38:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/11114010/1

[commit-bot: I haz the power, 2012-10-13 08:16:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/11114010/1

[Hongbo Min, 2012-10-13 09:40:37]

On 2012/10/13 08:16:21, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/hongbo.min%40intel.com/11114010/1

Seems that this patch can not be committed. I waited it for a long time. But
http://codereview.chromium.org/10905171/ was already re-committed, it causes the
static initializer checking still regressed.

Do you know what happen for this patch? Thanks

[Hongbo Min, 2012-10-13 09:41:37]

On 2012/10/13 09:40:37, Hongbo Min wrote:
> On 2012/10/13 08:16:21, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/hongbo.min%2540intel.com/11114010/1
> 
Seems that this patch can not be committed. I waited it for a long time. But
http://codereview.chromium.org/10905171/ was already re-committed, it causes the
static initializer checking still regressed without this patch landed.

Do you know what happen for this patch? Thanks

[commit-bot: I haz the power, 2012-10-13 09:49:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/11114010/1

[commit-bot: I haz the power, 2012-10-13 10:24:46]

Change committed as 161756

[Hongbo Min, 2012-10-13 10:49:05]

On 2012/10/13 09:41:37, Hongbo Min wrote:
> On 2012/10/13 09:40:37, Hongbo Min wrote:
> > On 2012/10/13 08:16:21, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >
https://chromium-status.appspot.com/cq/hongbo.min%252540intel.com/11114010/1
> > 
> Seems that this patch can not be committed. I waited it for a long time. But
> http://codereview.chromium.org/10905171/ was already re-committed, it causes
the
> static initializer checking still regressed without this patch landed.
> 
> Do you know what happen for this patch? Thanks

Sorry, it has been committed. Seem the buildbot has a big latency to commit.

[Hongbo Min, 2012-10-13 10:49:06]

On 2012/10/13 09:41:37, Hongbo Min wrote:
> On 2012/10/13 09:40:37, Hongbo Min wrote:
> > On 2012/10/13 08:16:21, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >
https://chromium-status.appspot.com/cq/hongbo.min%252540intel.com/11114010/1
> > 
> Seems that this patch can not be committed. I waited it for a long time. But
> http://codereview.chromium.org/10905171/ was already re-committed, it causes
the
> static initializer checking still regressed without this patch landed.
> 
> Do you know what happen for this patch? Thanks

Sorry, it has been committed. Seem the buildbot has a big latency to commit.