chrome/browser/resources/options/home_page_overlay.html - Issue 11096020: Add first batch of controlled setting indicators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/home_page_overlay.html

Issue 11096020: Add first batch of controlled setting indicators (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment addressed. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/home_page_overlay.html

diff --git a/chrome/browser/resources/options/home_page_overlay.html b/chrome/browser/resources/options/home_page_overlay.html

index 2329507ce940fe29f55c3fe74ccafb7ecc97d79b..b6da4e5c1b735bc7b945ec01af4b466d8f60f520 100644

--- a/chrome/browser/resources/options/home_page_overlay.html

+++ b/chrome/browser/resources/options/home_page_overlay.html

@@ -9,17 +9,24 @@

metric="Options_Homepage_IsNewTabPage" dialog-pref>

</label>

+ <span class="controlled-setting-indicator" pref="homepage_is_newtabpage"

+ value="true" dialog-pref>

+ </span>

</div>

- <div class="radio">

+ <div id="homepage-url-line" class="radio">

<label>

- <input id="homepage-use-url" type="radio" name="homepage"

- pref="homepage_is_newtabpage" value="false"

- metric="Options_Homepage_IsNewTabPage" dialog-pref>

+ <input type="radio" name="homepage" pref="homepage_is_newtabpage"

+ value="false" metric="Options_Homepage_IsNewTabPage" dialog-pref>

</label>

+ <span class="controlled-setting-indicator" pref="homepage_is_newtabpage"

+ value="false" dialog-pref></span>

James Hawkins 2012/10/09 15:17:11 nit: Closing brace for a wrapped element must be o

bartfab (slow) 2012/10/09 15:22:06 Done.

<input id="homepage-url-field" type="url" data-type="url"

- class="weakrtl favicon-cell hbox stretch"

- pref="homepage" dialog-pref>

+ class="weakrtl favicon-cell stretch" pref="homepage"

+ dialog-pref></input>

+ <span id="homepage-url-field-indicator"

+ class="controlled-setting-indicator" pref="homepage"

+ dialog-pref></span>

</div>