chrome/browser/resources/options/home_page_overlay.html - Issue 11096020: Add first batch of controlled setting indicators

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/home_page_overlay.html

Issue 11096020: Add first batch of controlled setting indicators (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment addressed. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <div id="home-page-overlay" class="page" hidden>	1 <div id="home-page-overlay" class="page" hidden>

2 <div class="close-button"></div>	2 <div class="close-button"></div>

3 <h1 i18n-content="homePageOverlay"></h1>	3 <h1 i18n-content="homePageOverlay"></h1>

4 <div class="content-area">	4 <div class="content-area">

5 <div class="radio">	5 <div class="radio">

6 <label>	6 <label>

7 <input id="homepage-use-ntp" type="radio" name="homepage"	7 <input id="homepage-use-ntp" type="radio" name="homepage"

8 pref="homepage_is_newtabpage" value="true"	8 pref="homepage_is_newtabpage" value="true"

9 metric="Options_Homepage_IsNewTabPage" dialog-pref>	9 metric="Options_Homepage_IsNewTabPage" dialog-pref>

10 <span i18n-content="homePageUseNewTab"></span>	10 <span i18n-content="homePageUseNewTab"></span>

11 </label>	11 </label>

	12 <span class="controlled-setting-indicator" pref="homepage_is_newtabpage"

	13 value="true" dialog-pref>

	14 </span>

12 </div>	15 </div>

13 <div class="radio">	16 <div id="homepage-url-line" class="radio">

14 <label>	17 <label>

15 <input id="homepage-use-url" type="radio" name="homepage"	18 <input type="radio" name="homepage" pref="homepage_is_newtabpage"

16 pref="homepage_is_newtabpage" value="false"	19 value="false" metric="Options_Homepage_IsNewTabPage" dialog-pref>

17 metric="Options_Homepage_IsNewTabPage" dialog-pref>

18 <span i18n-content="homePageUseURL"></span>	20 <span i18n-content="homePageUseURL"></span>

19 </label>	21 </label>

	22 <span class="controlled-setting-indicator" pref="homepage_is_newtabpage"

	23 value="false" dialog-pref></span>
	James Hawkins 2012/10/09 15:17:11 nit: Closing brace for a wrapped element must be o nit: Closing brace for a wrapped element must be on a new line. Here and elsewhere. bartfab (slow) 2012/10/09 15:22:06 Done. Show quoted text On 2012/10/09 15:17:11, James Hawkins wrote: > nit: Closing brace for a wrapped element must be on a new line. > > Here and elsewhere. Done.
20 <input id="homepage-url-field" type="url" data-type="url"	24 <input id="homepage-url-field" type="url" data-type="url"

21 class="weakrtl favicon-cell hbox stretch"	25 class="weakrtl favicon-cell stretch" pref="homepage"

22 pref="homepage" dialog-pref>	26 dialog-pref></input>

	27 <span id="homepage-url-field-indicator"

	28 class="controlled-setting-indicator" pref="homepage"

	29 dialog-pref></span>

23 </div>	30 </div>

24 </div>	31 </div>

25 <div class="action-area">	32 <div class="action-area">

26 <div class="button-strip">	33 <div class="button-strip">

27 <button id="home-page-cancel" type="reset" i18n-content="cancel">	34 <button id="home-page-cancel" type="reset" i18n-content="cancel">

28 </button>	35 </button>

29 <button id="home-page-confirm" i18n-content="ok"></button>	36 <button id="home-page-confirm" i18n-content="ok"></button>

30 </div>	37 </div>

31 </div>	38 </div>

32 </div>	39 </div>

OLD	NEW

« no previous file with comments | « chrome/browser/resources/options/home_page_overlay.css ('k') | chrome/browser/resources/options/home_page_overlay.js » ('j') | no next file with comments »