Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.cc
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index 425db17c41f1ba75c5a7464b7f5fc87a814d2f88..ad9325c1c9faf3939d5a585de3562e08ca6cac6e 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -256,7 +256,9 @@ class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
}
// Simulate a user abort on an extension installation.
- virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
+ virtual void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) {
delegate->InstallUIAbort(true);
MessageLoopForUI::current()->Quit();
}
@@ -274,7 +276,9 @@ class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
Profile* profile) : ExtensionInstallPrompt(parent, navigator, profile) {}
// Proceed without confirmation prompt.
- virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
+ virtual void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) {
delegate->InstallUIProceed();
}
};

Powered by Google App Engine
This is Rietveld 408576698