Making ShowExtensionInstallDialog a callback

chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index 9959e34c19341ec63d0c451767af5b9a71cf9d56..3c0266c369dea685f1fd844f96a3028fa4a63fad 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -14,7 +14,6 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_function_dispatcher.h"
-#include "chrome/browser/extensions/extension_install_dialog.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/webstore_installer.h"
@@ -325,7 +324,11 @@ void BeginInstallWithManifestFunction::OnWebstoreParseSuccess(
 
   install_prompt_.reset(
       chrome::CreateExtensionInstallPromptWithBrowser(GetCurrentBrowser()));
-  install_prompt_->ConfirmWebstoreInstall(this, dummy_extension_, &icon_);
+  install_prompt_->ConfirmWebstoreInstall(
+      this,
+      dummy_extension_,
+      &icon_,
+      ExtensionInstallPrompt::ShowDialogCallback());

[Aaron Boodman, 2012/10/11 20:28:50]

This is super confusing. I thought this was a function call or something, but
it's creating an empty Callback instance.

I guess this is because callbacks must be passed by value, so you can't pass
NULL?

In that case, I think it is better the way you had -- with a method somewhere to
get the default impl of this callback.

Sorry for the flip flop.

[sail, 2012/10/11 21:18:47]

Changed to ExtensionInstallPrompt::GetDefaultShowDialogCallback() instead.

   // Control flow finishes up in InstallUIProceed or InstallUIAbort.
 }