Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('K') | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | chrome/browser/extensions/extension_install_prompt.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index e51b225e73cc7387a1d99a46ae2642909fd82dcb..61396a5a6b14bb7329a2b18ad502002270dbfe32 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -124,6 +124,8 @@ CrxInstaller::CrxInstaller(
expected_id_ = approval->extension_id;
record_oauth2_grant_ = approval->record_oauth2_grant;
}
+
+ show_dialog_callback_ = approval->show_dialog_callback;
}
CrxInstaller::~CrxInstaller() {
@@ -453,7 +455,7 @@ void CrxInstaller::ConfirmInstall() {
if (client_ && (!allow_silent_install_ || !approved_)) {
AddRef(); // Balanced in Proceed() and Abort().
- client_->ConfirmInstall(this, extension_.get());
+ client_->ConfirmInstall(this, extension_.get(), show_dialog_callback_);
} else {
if (!BrowserThread::PostTask(
BrowserThread::FILE, FROM_HERE,
« chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('K') | « chrome/browser/extensions/crx_installer.h ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | chrome/browser/extensions/extension_install_prompt.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698