Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5463)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 63904590ccdb0380970bf86fed24226491a919b5..4e41aa1e362f4e3c64a943b44fec129ee506a1db 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -149,7 +149,9 @@ class MockAbortExtensionInstallPrompt : public ExtensionInstallPrompt {
}
// Simulate a user abort on an extension installation.
- virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
+ virtual void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) {
delegate->InstallUIAbort(true);
MessageLoopForUI::current()->Quit();
}
@@ -169,7 +171,9 @@ class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
: ExtensionInstallPrompt(parent, navigator, profile) {}
// Proceed without confirmation prompt.
- virtual void ConfirmInstall(Delegate* delegate, const Extension* extension) {
+ virtual void ConfirmInstall(Delegate* delegate,
+ const Extension* extension,
+ const ShowDialogCallback& show_dialog_callback) {
delegate->InstallUIProceed();
}

Powered by Google App Engine
This is Rietveld 408576698