Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message.

lib/compiler/implementation/warnings.dart

Index: lib/compiler/implementation/warnings.dart
diff --git a/lib/compiler/implementation/warnings.dart b/lib/compiler/implementation/warnings.dart
index 240fe5874eadd3cc9bebe927428d088d4c658033..8cb4486c5121bab689e6d71024e2d076194afd4c 100644
--- a/lib/compiler/implementation/warnings.dart
+++ b/lib/compiler/implementation/warnings.dart
@@ -297,6 +297,9 @@ Length: #{3}''');
   static const PATCH_PARAMETER_MISMATCH = const MessageKind(
       "Patch method parameter '#{3}' doesn't match '#{2}' on origin method "
       "#{1}.");
+  
+  static const LIBRARY_VARIABLE_AS_STATIC = const MessageKind(
+      "The library variable '#{1}' is implicitly static, but is also declared as static, remove the static keyword.");

[ahe, 2012/10/09 10:55:28]

Long line.

[ahe, 2012/10/09 10:55:28]

library variable -> top-level variable.

I think this error should just be:

"top-level variable cannot be declared static"

[jwren, 2012/10/09 12:55:26]

Done.

 
   static const COMPILER_CRASHED = const MessageKind(
       "Error: The compiler crashed when compiling this element.");