Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message.

lib/compiler/implementation/resolver.dart

Index: lib/compiler/implementation/resolver.dart
diff --git a/lib/compiler/implementation/resolver.dart b/lib/compiler/implementation/resolver.dart
index 7f2a06750e7d4ae7d34a0ab7fb1a649204eaa7cc..e71f53cad4d4bd3c878f0c683cd71254b5b538d6 100644
--- a/lib/compiler/implementation/resolver.dart
+++ b/lib/compiler/implementation/resolver.dart
@@ -313,8 +313,11 @@ class ResolverTask extends CompilerTask {
     }
   }
 
-  TreeElements resolveField(Element element) {
+  TreeElements resolveField(VariableElement element) {
     Node tree = element.parseNode(compiler);
+    if(element.modifiers.isStatic() && element.variables.isTopLevel()) {
+      error(tree, MessageKind.LIBRARY_VARIABLE_AS_STATIC, [element.name]);

[ahe, 2012/10/09 10:55:28]

The position should be the static keyword, I think.

[jwren, 2012/10/09 12:55:26]

Done.

+    }
     ResolverVisitor visitor = new ResolverVisitor(compiler, element);
     initializerDo(tree, visitor.visit);
     return visitor.mapping;