Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: lib/compiler/implementation/warnings.dart

Issue 11087025: Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixed merge mistake. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/warnings.dart
diff --git a/lib/compiler/implementation/warnings.dart b/lib/compiler/implementation/warnings.dart
index 240fe5874eadd3cc9bebe927428d088d4c658033..8cb4486c5121bab689e6d71024e2d076194afd4c 100644
--- a/lib/compiler/implementation/warnings.dart
+++ b/lib/compiler/implementation/warnings.dart
@@ -297,6 +297,9 @@ Length: #{3}''');
static const PATCH_PARAMETER_MISMATCH = const MessageKind(
"Patch method parameter '#{3}' doesn't match '#{2}' on origin method "
"#{1}.");
+
+ static const LIBRARY_VARIABLE_AS_STATIC = const MessageKind(
+ "The library variable '#{1}' is implicitly static, but is also declared as static, remove the static keyword.");
static const COMPILER_CRASHED = const MessageKind(
"Error: The compiler crashed when compiling this element.");

Powered by Google App Engine
This is Rietveld 408576698