Fix to dartbug.com/5170, explictly static library variables now get an appropriate error message.

lib/compiler/implementation/resolver.dart

Index: lib/compiler/implementation/resolver.dart
diff --git a/lib/compiler/implementation/resolver.dart b/lib/compiler/implementation/resolver.dart
index 7f2a06750e7d4ae7d34a0ab7fb1a649204eaa7cc..c0a7b149a63a8e5dd74aa27db503620430d445b8 100644
--- a/lib/compiler/implementation/resolver.dart
+++ b/lib/compiler/implementation/resolver.dart
@@ -315,6 +315,9 @@ class ResolverTask extends CompilerTask {
 
   TreeElements resolveField(Element element) {

[ahe, 2012/10/09 10:20:09]

Element -> VariableElement.

[jwren, 2012/10/09 10:31:15]

Done.

     Node tree = element.parseNode(compiler);
+    if(element.modifiers.isStatic() && element.getEnclosingClassOrCompilationUnit().isCompilationUnit()) {

[ahe, 2012/10/09 10:20:09]

Long line.

[ahe, 2012/10/09 10:20:09]

I think it should element.variables.isTopLevel(), not element.getEnclosing...

[jwren, 2012/10/09 10:31:15]

Done- changing it to element.variables.isTopLevel() shorten the length of the
line down to 73 chars.

+      error(tree, MessageKind.LIBRARY_VARIABLE_AS_STATIC, [element.name]);
+    }
     ResolverVisitor visitor = new ResolverVisitor(compiler, element);
     initializerDo(tree, visitor.visit);
     return visitor.mapping;