Improving window auto management between workspaces

chrome/browser/ui/views/frame/browser_frame_aura.cc

Index: chrome/browser/ui/views/frame/browser_frame_aura.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame_aura.cc b/chrome/browser/ui/views/frame/browser_frame_aura.cc
index 764e95b5d6a15431b838c9ceef87a95023cc48b8..c7a2df2dc1f5da4feef68b5522f912df3dda5316 100644
--- a/chrome/browser/ui/views/frame/browser_frame_aura.cc
+++ b/chrome/browser/ui/views/frame/browser_frame_aura.cc
@@ -24,6 +24,7 @@
 
 #if defined(USE_ASH)
 #include "ash/wm/property_util.h"
+#include "ash/wm/window_util.h"
 #endif
 
 #if !defined(OS_CHROMEOS)
@@ -109,6 +110,12 @@ BrowserFrameAura::BrowserFrameAura(BrowserFrame* browser_frame,
     ash::SetPersistsAcrossAllWorkspaces(
         GetNativeWindow(),
         ash::WINDOW_PERSISTS_ACROSS_ALL_WORKSPACES_VALUE_NO);
+    // Also mark this window as automatically position managed.
+    ash::wm::SetWindowPositionManaged(GetNativeWindow(), true);
+    // If the browser got restored and was previously positioned by the user,
+    // the flag gets restored.
+    if (browser_view->browser()->initial_user_has_changed_window_or_position())

[sky, 2012/10/17 15:59:38]

I don't think we should persist this. That's too mysterious. Who can remember
whether they actually moved a window from the last session?

The only thing we really need is to make sure when restoring we create the
window with the specified bounds. This is also needed for other places that want
to create a browser at a specific location (such as tab dragging).

[Mr4D (OOO till 08-26), 2012/10/17 18:43:56]

If we don't, the desktop will not be restored to the previous state upon
restart. This *is* unfortunately necessary. I talked with kuscher and he agrees
that the restoration of the previous desktop is required.

[sky, 2012/10/18 16:11:19]

smaller patches=easier to review and land .

Can you push this to another patch? Otherwise this one is likely to drag on
longer.

[Mr4D (OOO till 08-26), 2012/10/19 20:46:04]

Since the requirement has changed this was removed.

+      ash::wm::SetUserHasChangedWindowPositionOrSize(GetNativeWindow(), true);
   }
 #endif
 }