Improving window auto management between workspaces

chrome/browser/ui/views/frame/browser_frame_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_frame_aura.h"
 
 #include "base/command_line.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/system_menu_model_delegate.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_observer.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/gfx/font.h"
 #include "ui/views/controls/menu/menu_model_adapter.h"
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/view.h"
 #include "ui/views/views_switches.h"
 
 #if defined(USE_ASH)
 #include "ash/wm/property_util.h"
+#include "ash/wm/window_util.h"
 #endif
 
 #if !defined(OS_CHROMEOS)
 #include "chrome/browser/ui/views/frame/desktop_browser_frame_aura.h"
 #endif
 
 using aura::Window;
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserFrameAura::WindowPropertyWatcher
@@ skipping 65 matching lines @@
   GetNativeWindow()->SetName("BrowserFrameAura");
   GetNativeWindow()->AddObserver(window_property_watcher_.get());
 #if defined(USE_ASH)
   // Tabbed browsers and apps (some apps are TYPE_POPUP) get their own
   // workspace.
   if (browser_view->browser()->type() != Browser::TYPE_POPUP ||
       browser_view->browser()->is_app()) {
     ash::SetPersistsAcrossAllWorkspaces(
         GetNativeWindow(),
         ash::WINDOW_PERSISTS_ACROSS_ALL_WORKSPACES_VALUE_NO);
+    // Also mark this window as automatically position managed.
+    ash::wm::SetWindowPositionManaged(GetNativeWindow(), true);
+    // If the browser got restored and was previously positioned by the user,
+    // the flag gets restored.
+    if (browser_view->browser()->initial_user_has_changed_window_or_position())

[sky, 2012/10/17 15:59:38]

I don't think we should persist this. That's too mysterious. Who can remember
whether they actually moved a window from the last session?

The only thing we really need is to make sure when restoring we create the
window with the specified bounds. This is also needed for other places that want
to create a browser at a specific location (such as tab dragging).

[Mr4D (OOO till 08-26), 2012/10/17 18:43:56]

If we don't, the desktop will not be restored to the previous state upon
restart. This *is* unfortunately necessary. I talked with kuscher and he agrees
that the restoration of the previous desktop is required.

[sky, 2012/10/18 16:11:19]

smaller patches=easier to review and land .

Can you push this to another patch? Otherwise this one is likely to drag on
longer.

[Mr4D (OOO till 08-26), 2012/10/19 20:46:04]

Since the requirement has changed this was removed.

+      ash::wm::SetUserHasChangedWindowPositionOrSize(GetNativeWindow(), true);
   }
 #endif
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserFrameAura, views::ContextMenuController overrides:
 void BrowserFrameAura::ShowContextMenuForView(views::View* source,
                                               const gfx::Point& p) {
   // Only show context menu if point is in unobscured parts of browser, i.e.
   // if NonClientHitTest returns :
@@ skipping 91 matching lines @@
     return new DesktopBrowserFrameAura(browser_frame, browser_view);
 #endif
   return new BrowserFrameAura(browser_frame, browser_view);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserFrameAura, private:
 
 BrowserFrameAura::~BrowserFrameAura() {
 }