chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm - Issue 11077006: Correct padding and focus ring for frameless constrained window dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm

Issue 11077006: Correct padding and focus ring for frameless constrained window dialog (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix mac build, part 2 Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.mm ('k') | chrome/browser/ui/constrained_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm b/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm

index af95fb66c9aa762e8b59b7b932596f54212ad9aa..3cafc659ca59469e1e99243fe0c1f86537c1e5bd 100644

--- a/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm

+++ b/chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm

@@ -146,7 +146,7 @@

NSRect bounds = NSInsetRect(innerFrame,

-ConstrainedWindow::kHorizontalPadding,

- -ConstrainedWindow::kVerticalPadding);

+ -ConstrainedWindow::kClientBottomPadding);

sail 2012/10/11 18:15:23 this will not work this insets the entire rect (to

please use gerrit instead 2012/10/11 18:41:27 Done.

[[viewController view] setFrame:bounds];

[viewController layoutSubviewsWithinFrame:innerFrame];

@@ -166,7 +166,7 @@

WebIntentPicker::kWindowMinHeight);

return NSInsetRect(bounds,

ConstrainedWindow::kHorizontalPadding,

- ConstrainedWindow::kVerticalPadding);

+ ConstrainedWindow::kClientBottomPadding);

sail 2012/10/11 18:15:23 same as above

please use gerrit instead 2012/10/11 18:41:27 Done.

}

- (NSViewController<WebIntentViewController>*)currentViewController {

« no previous file with comments | « chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.mm ('k') | chrome/browser/ui/constrained_window.h » ('j') | no next file with comments »