Correct padding and focus ring for frameless constrained window dialog

chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/intents/web_intent_picker_view_controller.h"
 
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/ui/cocoa/event_utils.h"
 #import "chrome/browser/ui/cocoa/flipped_view.h"
 #import "chrome/browser/ui/cocoa/hover_close_button.h"
@@ skipping 128 matching lines @@
   NSSize minSize =
       [viewController minimumSizeForInnerWidth:NSWidth(innerFrame)];
   innerFrame.size.width = std::max(minSize.width, NSWidth(innerFrame));
   innerFrame.size.width = std::min(
       static_cast<CGFloat>(WebIntentPicker::kWindowMaxWidth),
       NSWidth(innerFrame));
   innerFrame.size.height = std::max(minSize.height, NSHeight(innerFrame));
 
   NSRect bounds = NSInsetRect(innerFrame,
                               -ConstrainedWindow::kHorizontalPadding,
-                              -ConstrainedWindow::kVerticalPadding);
+                              -ConstrainedWindow::kClientBottomPadding);

[sail, 2012/10/11 18:15:23]

this will not work
this insets the entire rect (top and bottom).
you'll bounds.origin.y = top_padding
bounds.size.height = NSHeight(innerFrame) - top_padding - bottom_padding

[please use gerrit instead, 2012/10/11 18:41:27]

Done.

 
   [[viewController view] setFrame:bounds];
   [viewController layoutSubviewsWithinFrame:innerFrame];
 
   NSRect closeFrame;
   closeFrame.size.width = ConstrainedWindow::GetCloseButtonSize();
   closeFrame.size.height = ConstrainedWindow::GetCloseButtonSize();
   closeFrame.origin.x = NSMaxX(innerFrame) - NSWidth(closeFrame);
   closeFrame.origin.y = NSMinY(innerFrame);
   [closeButton_ setFrame:closeFrame];
 
   [[self view] setFrame:bounds];
 }
 
 - (NSRect)minimumInnerFrame {
   NSRect bounds = NSMakeRect(0, 0, WebIntentPicker::kWindowMinWidth,
                              WebIntentPicker::kWindowMinHeight);
   return NSInsetRect(bounds,
                      ConstrainedWindow::kHorizontalPadding,
-                     ConstrainedWindow::kVerticalPadding);
+                     ConstrainedWindow::kClientBottomPadding);

[sail, 2012/10/11 18:15:23]

same as above

[please use gerrit instead, 2012/10/11 18:41:27]

Done.

 }
 
 - (NSViewController<WebIntentViewController>*)currentViewController {
   switch (state_) {
     case PICKER_STATE_WAITING:
       return progressViewController_;
     case PICKER_STATE_NO_SERVICE:
       return messageViewController_;
     case PICKER_STATE_CHOOSE_SERVICE:
       return chooseServiceViewController_;
@@ skipping 135 matching lines @@
   picker_->delegate()->OnExtensionLinkClicked(service.id, disposition);
 }
 
 - (void)onShowMoreServices:(id)sender {
   WindowOpenDisposition disposition =
       event_utils::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);
   picker_->delegate()->OnSuggestionsLinkClicked(disposition);
 }
 
 @end