Issue 1105010: Alter the "get themes" action on Mac to behave like other platforms; fix bugs...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1105010: Alter the "get themes" action on Mac to behave like other platforms; fix bugs... (Closed)

Created:
10 years, 9 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Alter the "get themes" action on Mac to behave like other platforms; fix bugs. BUG=http://crbug.com/38002 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42374

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

		Unified diffs	Side-by-side diffs	Stats (+3 lines, -11 lines)
	M	chrome/browser/cocoa/preferences_window_controller.mm	View	1 chunk	+3 lines, -11 lines	1 comment

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

http://codereview.chromium.org/1105010/diff/1/2 File chrome/browser/cocoa/preferences_window_controller.mm (right): http://codereview.chromium.org/1105010/diff/1/2#newcode1315 chrome/browser/cocoa/preferences_window_controller.mm:1315: Browser* browser = BrowserList::GetLastActive(); BTW, you don't have to ...

10 years, 9 months ago (2010-03-23 16:24:11 UTC) #2

lgtm

Expand Messages | Collapse Messages