Alter the "get themes" action on Mac to behave like other platforms; fix bugs...

chrome/browser/cocoa/preferences_window_controller.mm

Index: chrome/browser/cocoa/preferences_window_controller.mm
===================================================================
--- chrome/browser/cocoa/preferences_window_controller.mm	(revision 42237)
+++ chrome/browser/cocoa/preferences_window_controller.mm	(working copy)
@@ -1312,19 +1312,11 @@
 
 - (IBAction)themesGallery:(id)sender {
   [self recordUserAction:"Options_ThemesGallery"];
-  Browser* browser =
-      BrowserList::FindBrowserWithType(profile_, Browser::TYPE_NORMAL);
+  Browser* browser = BrowserList::GetLastActive();

[Avi (use Gerrit), 2010/03/23 16:24:14]

BTW, you don't have to worry about finding the "normal" (i.e. non-popup)
browser; opening a link in a popup will find the first non-popup. With this
change we behave like everyone else.

 
-  if (!browser || !browser->GetSelectedTabContents()) {
+  if (!browser || !browser->GetSelectedTabContents())
     browser = Browser::Create(profile_);
-    browser->OpenURL(
-        GURL(l10n_util::GetStringUTF8(IDS_THEMES_GALLERY_URL)),
-        GURL(), NEW_WINDOW, PageTransition::LINK);
-  } else {
-    browser->OpenURL(
-        GURL(l10n_util::GetStringUTF8(IDS_THEMES_GALLERY_URL)),
-        GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
-  }
+  browser->OpenThemeGalleryTabAndActivate();
 }
 
 // Called when the "stop syncing" confirmation dialog started by