Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: media/base/android/media_player_bridge.cc

Issue 11038015: Android: lazy initialization for method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moves to MethodID Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_player_bridge.cc
diff --git a/media/base/android/media_player_bridge.cc b/media/base/android/media_player_bridge.cc
index 7d5aa0847eec1d97e3c8a5206ac03c100f252547..464b1f75b66dff87f0be048afe15edf313e576fd 100644
--- a/media/base/android/media_player_bridge.cc
+++ b/media/base/android/media_player_bridge.cc
@@ -19,7 +19,7 @@ using base::android::AttachCurrentThread;
using base::android::CheckException;
using base::android::ConvertUTF8ToJavaString;
using base::android::GetClass;
-using base::android::GetMethodID;
+using base::android::MethodID;
using base::android::JavaRef;
using base::android::ScopedJavaLocalRef;
@@ -319,9 +319,10 @@ void MediaPlayerBridge::GetMetadata() {
ScopedJavaLocalRef<jclass> media_player_class(
GetClass(env, "android/media/MediaPlayer"));
- jmethodID method = GetMethodID(
- env, media_player_class, "getMetadata",
- "(ZZ)Landroid/media/Metadata;");
+ jmethodID method = MethodID::Get<
+ MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
+ env, media_player_class.obj(), "getMetadata",
+ "(ZZ)Landroid/media/Metadata;");
ScopedJavaLocalRef<jobject> j_metadata(
env, env->CallObjectMethod(
j_media_player_.obj(), method, JNI_FALSE, JNI_FALSE));
@@ -331,8 +332,9 @@ void MediaPlayerBridge::GetMetadata() {
ScopedJavaLocalRef<jclass> metadata_class(
GetClass(env, "android/media/Metadata"));
- jmethodID get_boolean = GetMethodID(
- env, metadata_class, "getBoolean", "(I)Z");
+ jmethodID get_boolean = MethodID::Get<
+ MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
+ env, metadata_class.obj(), "getBoolean", "(I)Z");
can_pause_ = env->CallBooleanMethod(j_metadata.obj(),
get_boolean,
kPauseAvailable);

Powered by Google App Engine
This is Rietveld 408576698