Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: media/base/android/media_player_bridge.cc

Issue 11038015: Android: lazy initialization for method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moves to MethodID Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/android/media_player_bridge.h" 5 #include "media/base/android/media_player_bridge.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/stringprintf.h" 11 #include "base/stringprintf.h"
12 #include "base/message_loop_proxy.h" 12 #include "base/message_loop_proxy.h"
13 #include "jni/MediaPlayerBridge_jni.h" 13 #include "jni/MediaPlayerBridge_jni.h"
14 #include "jni/MediaPlayer_jni.h" 14 #include "jni/MediaPlayer_jni.h"
15 #include "media/base/android/cookie_getter.h" 15 #include "media/base/android/cookie_getter.h"
16 #include "media/base/android/media_player_bridge_manager.h" 16 #include "media/base/android/media_player_bridge_manager.h"
17 17
18 using base::android::AttachCurrentThread; 18 using base::android::AttachCurrentThread;
19 using base::android::CheckException; 19 using base::android::CheckException;
20 using base::android::ConvertUTF8ToJavaString; 20 using base::android::ConvertUTF8ToJavaString;
21 using base::android::GetClass; 21 using base::android::GetClass;
22 using base::android::GetMethodID; 22 using base::android::MethodID;
23 using base::android::JavaRef; 23 using base::android::JavaRef;
24 using base::android::ScopedJavaLocalRef; 24 using base::android::ScopedJavaLocalRef;
25 25
26 // These constants are from the android source tree and need to be kept in 26 // These constants are from the android source tree and need to be kept in
27 // sync with android/media/MediaMetadata.java. 27 // sync with android/media/MediaMetadata.java.
28 static const jint kPauseAvailable = 1; 28 static const jint kPauseAvailable = 1;
29 static const jint kSeekBackwardAvailable = 2; 29 static const jint kSeekBackwardAvailable = 2;
30 static const jint kSeekForwardAvailable = 3; 30 static const jint kSeekForwardAvailable = 3;
31 31
32 // Time update happens every 250ms. 32 // Time update happens every 250ms.
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 312
313 media_prepared_cb_.Run(player_id_, duration_); 313 media_prepared_cb_.Run(player_id_, duration_);
314 } 314 }
315 315
316 void MediaPlayerBridge::GetMetadata() { 316 void MediaPlayerBridge::GetMetadata() {
317 JNIEnv* env = AttachCurrentThread(); 317 JNIEnv* env = AttachCurrentThread();
318 CHECK(env); 318 CHECK(env);
319 319
320 ScopedJavaLocalRef<jclass> media_player_class( 320 ScopedJavaLocalRef<jclass> media_player_class(
321 GetClass(env, "android/media/MediaPlayer")); 321 GetClass(env, "android/media/MediaPlayer"));
322 jmethodID method = GetMethodID( 322 jmethodID method = MethodID::Get<
323 env, media_player_class, "getMetadata", 323 MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
324 "(ZZ)Landroid/media/Metadata;"); 324 env, media_player_class.obj(), "getMetadata",
325 "(ZZ)Landroid/media/Metadata;");
325 ScopedJavaLocalRef<jobject> j_metadata( 326 ScopedJavaLocalRef<jobject> j_metadata(
326 env, env->CallObjectMethod( 327 env, env->CallObjectMethod(
327 j_media_player_.obj(), method, JNI_FALSE, JNI_FALSE)); 328 j_media_player_.obj(), method, JNI_FALSE, JNI_FALSE));
328 CheckException(env); 329 CheckException(env);
329 if (j_metadata.is_null()) 330 if (j_metadata.is_null())
330 return; 331 return;
331 332
332 ScopedJavaLocalRef<jclass> metadata_class( 333 ScopedJavaLocalRef<jclass> metadata_class(
333 GetClass(env, "android/media/Metadata")); 334 GetClass(env, "android/media/Metadata"));
334 jmethodID get_boolean = GetMethodID( 335 jmethodID get_boolean = MethodID::Get<
335 env, metadata_class, "getBoolean", "(I)Z"); 336 MethodID::METHODTYPE_NORMAL, MethodID::EXCEPTIONCHECK_YES>(
337 env, metadata_class.obj(), "getBoolean", "(I)Z");
336 can_pause_ = env->CallBooleanMethod(j_metadata.obj(), 338 can_pause_ = env->CallBooleanMethod(j_metadata.obj(),
337 get_boolean, 339 get_boolean,
338 kPauseAvailable); 340 kPauseAvailable);
339 CheckException(env); 341 CheckException(env);
340 can_seek_forward_ = env->CallBooleanMethod(j_metadata.obj(), 342 can_seek_forward_ = env->CallBooleanMethod(j_metadata.obj(),
341 get_boolean, 343 get_boolean,
342 kSeekBackwardAvailable); 344 kSeekBackwardAvailable);
343 CheckException(env); 345 CheckException(env);
344 can_seek_backward_ = env->CallBooleanMethod(j_metadata.obj(), 346 can_seek_backward_ = env->CallBooleanMethod(j_metadata.obj(),
345 get_boolean, 347 get_boolean,
(...skipping 29 matching lines...) Expand all
375 377
376 bool MediaPlayerBridge::RegisterMediaPlayerBridge(JNIEnv* env) { 378 bool MediaPlayerBridge::RegisterMediaPlayerBridge(JNIEnv* env) {
377 bool ret = RegisterNativesImpl(env); 379 bool ret = RegisterNativesImpl(env);
378 DCHECK(g_MediaPlayerBridge_clazz); 380 DCHECK(g_MediaPlayerBridge_clazz);
379 if (ret) 381 if (ret)
380 ret = JNI_MediaPlayer::RegisterNativesImpl(env); 382 ret = JNI_MediaPlayer::RegisterNativesImpl(env);
381 return ret; 383 return ret;
382 } 384 }
383 385
384 } // namespace media 386 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698