Mac Web Intents Part 15: Inline extension install prompt (model)

chrome/browser/ui/intents/web_intent_picker_model.h

Index: chrome/browser/ui/intents/web_intent_picker_model.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_model.h b/chrome/browser/ui/intents/web_intent_picker_model.h
index d3fcaf18b557dfa60f7176ccfe36fbea89c795f3..69df2125e57771bd69924732ef18e55afa1cc522 100644
--- a/chrome/browser/ui/intents/web_intent_picker_model.h
+++ b/chrome/browser/ui/intents/web_intent_picker_model.h
@@ -9,6 +9,7 @@
 
 #include "base/basictypes.h"
 #include "base/string16.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
 #include "googleurl/src/gurl.h"
 #include "ui/gfx/image/image.h"
 #include "webkit/glue/web_intent_service_data.h"
@@ -180,6 +181,25 @@ class WebIntentPickerModel {
     return pending_extension_install_status_string_;
   }
 
+  // Sets the extension install delegate.
+  void SetPendingExtensionInstallDelegate(

[Greg Billock, 2012/10/03 17:20:35]

Should these go on the picker dialog itself? It doesn't seem like a model
member.

[sail, 2012/10/03 20:24:29]

Caching these values is really convenient for the picker UI. This way the picker
can see that the model has changed, run an animation, then pick up the new
values.

In the mean time it doesn't have to keep track of this state itself.

[Greg Billock, 2012/10/03 21:15:38]

OK. Like I was saying tearing out the intent data part may end up leaving a
picker dialog model with more dialog-related state, so this would be part of
that, right?

On 2012/10/03 20:24:29, sail wrote:

+      ExtensionInstallPrompt::Delegate* delegate);
+
+  // Gets the extension install delegate.
+  ExtensionInstallPrompt::Delegate* pending_extension_install_delegate() const {
+    return pending_extension_install_delegate_;
+  }
+
+  // Sets the extension install prompt.
+  void SetPendingExtensionInstallPrompt(
+      const ExtensionInstallPrompt::Prompt& prompt);
+
+  // Gets the extension install prompt.
+  const ExtensionInstallPrompt::Prompt* pending_extension_install_prompt()
+      const {
+    return pending_extension_install_prompt_.get();
+  }
+
   // Removes any pending extension install state.
   void ClearPendingExtensionInstall();
 
@@ -222,6 +242,8 @@ class WebIntentPickerModel {
   std::string pending_extension_install_id_;
   int pending_extension_install_download_progress_;
   string16 pending_extension_install_status_string_;
+  ExtensionInstallPrompt::Delegate* pending_extension_install_delegate_;
+  scoped_ptr<ExtensionInstallPrompt::Prompt> pending_extension_install_prompt_;
 
   DISALLOW_COPY_AND_ASSIGN(WebIntentPickerModel);
 };