Mac Web Intents Part 15: Inline extension install prompt (model)

chrome/browser/ui/intents/web_intent_picker_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_MODEL_H_
 #define CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_MODEL_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/string16.h"
+#include "chrome/browser/extensions/extension_install_prompt.h"
 #include "googleurl/src/gurl.h"
 #include "ui/gfx/image/image.h"
 #include "webkit/glue/web_intent_service_data.h"
 
 namespace content {
 class DownloadItem;
 }
 
 class WebIntentPickerModelObserver;
 
@@ skipping 151 matching lines @@
   }
 
   // Sets the status of extension install process.
   void SetPendingExtensionInstallStatusString(const string16& status);
 
   // Gets the status of extension install process.
   const string16& pending_extension_install_status_string() const {
     return pending_extension_install_status_string_;
   }
 
+  // Sets the extension install delegate.
+  void SetPendingExtensionInstallDelegate(

[Greg Billock, 2012/10/03 17:20:35]

Should these go on the picker dialog itself? It doesn't seem like a model
member.

[sail, 2012/10/03 20:24:29]

Caching these values is really convenient for the picker UI. This way the picker
can see that the model has changed, run an animation, then pick up the new
values.

In the mean time it doesn't have to keep track of this state itself.

[Greg Billock, 2012/10/03 21:15:38]

OK. Like I was saying tearing out the intent data part may end up leaving a
picker dialog model with more dialog-related state, so this would be part of
that, right?

On 2012/10/03 20:24:29, sail wrote:

+      ExtensionInstallPrompt::Delegate* delegate);
+
+  // Gets the extension install delegate.
+  ExtensionInstallPrompt::Delegate* pending_extension_install_delegate() const {
+    return pending_extension_install_delegate_;
+  }
+
+  // Sets the extension install prompt.
+  void SetPendingExtensionInstallPrompt(
+      const ExtensionInstallPrompt::Prompt& prompt);
+
+  // Gets the extension install prompt.
+  const ExtensionInstallPrompt::Prompt* pending_extension_install_prompt()
+      const {
+    return pending_extension_install_prompt_.get();
+  }
+
   // Removes any pending extension install state.
   void ClearPendingExtensionInstall();
 
  private:
   // Delete all elements in |installed_services_| and |suggested_extensions_|.
   // Note that this method does not reset the observer.
   void DestroyAll();
 
   // A vector of all installed services in the picker. Each installed service
   // is owned by this model.
@@ skipping 22 matching lines @@
   // Indicates that there are still open requests to CWS.
   bool waiting_for_suggestions_;
 
   // The hash context for the default service, if there is one.
   int64 default_service_hash_;
 
   // Information about the pending extension install.
   std::string pending_extension_install_id_;
   int pending_extension_install_download_progress_;
   string16 pending_extension_install_status_string_;
+  ExtensionInstallPrompt::Delegate* pending_extension_install_delegate_;
+  scoped_ptr<ExtensionInstallPrompt::Prompt> pending_extension_install_prompt_;
 
   DISALLOW_COPY_AND_ASSIGN(WebIntentPickerModel);
 };
 
 #endif  // CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_MODEL_H_