content/browser/download/download_resource_handler.h - Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_resource_handler.h

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_resource_handler.h

diff --git a/content/browser/download/download_resource_handler.h b/content/browser/download/download_resource_handler.h

index 8d07207e5b0cfaaeb68b3fa14b69a03eae45693d..36f51ab639b19a24f8dfa5e755c7e2b1dab1a304 100644

--- a/content/browser/download/download_resource_handler.h

+++ b/content/browser/download/download_resource_handler.h

@@ -41,7 +41,7 @@ class DownloadResourceHandler

DownloadResourceHandler(

net::URLRequest* request,

const OnStartedCallback& started_cb,

- const content::DownloadSaveInfo& save_info);

+ scoped_ptr<content::DownloadSaveInfo> save_info);

virtual bool OnUploadProgress(int request_id,

uint64 position,

@@ -106,7 +106,7 @@ class DownloadResourceHandler

// This is read only on the IO thread, but may only

// be called on the UI thread.

OnStartedCallback started_cb_;

- content::DownloadSaveInfo save_info_;

+ scoped_ptr<content::DownloadSaveInfo> save_info_;

// Data flow

scoped_refptr<net::IOBuffer> read_buffer_; // From URLRequest.