Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 11028131: Shift passage of FileStream in downloads system to be by scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated Al's comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index baaf531808efb1d9a6661499f84297b03a1472dd..3d18682768da0d0f15d7f00102b57d3640c55017 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -75,7 +75,7 @@ class SavePageData : public base::SupportsUserData::Data {
const char SavePageData::kKey[] = "DownloadItem SavePageData";
-void BeginDownload(content::DownloadUrlParameters* params) {
+void BeginDownload(scoped_ptr<content::DownloadUrlParameters> params) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
// ResourceDispatcherHost{Base} is-not-a URLRequest::Delegate, and
// DownloadUrlParameters can-not include resource_dispatcher_host_impl.h, so
@@ -116,7 +116,7 @@ void BeginDownload(content::DownloadUrlParameters* params) {
params->render_process_host_id(),
params->render_view_host_routing_id(),
params->prefer_cache(),
- params->save_info(),
+ params->GetSaveInfo(),
params->callback());
}
@@ -778,7 +778,7 @@ void DownloadManagerImpl::DownloadUrl(
DCHECK(params->method() == "POST");
}
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(
- &BeginDownload, base::Owned(params.release())));
+ &BeginDownload, base::Passed(params.Pass())));
}
void DownloadManagerImpl::AddObserver(Observer* observer) {
« no previous file with comments | « content/browser/download/download_item_impl_unittest.cc ('k') | content/browser/download/download_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698