Vboot Reference: Spring cleaning of test scripts.

Vboot Reference: Spring cleaning of test scripts.

Moved duplicated code to "common.sh". Make directory detection more robust.

[sosa, 2010-03-19 23:09:07]

nice cleanup!  it makes it much easier to read.  Just a cpl nits o/w lgtm

http://codereview.chromium.org/1101004/diff/1/2
File src/platform/vboot_reference/tests/common.sh (right):

http://codereview.chromium.org/1101004/diff/1/2#newcode32
src/platform/vboot_reference/tests/common.sh:32: 
Extra line

http://codereview.chromium.org/1101004/diff/1/5
File src/platform/vboot_reference/tests/gen_test_keys.sh (right):

http://codereview.chromium.org/1101004/diff/1/5#newcode26
src/platform/vboot_reference/tests/gen_test_keys.sh:26: if [ ! -d ${TESTKEY_DIR}
]
mkdir -p takes one line!

http://codereview.chromium.org/1101004/diff/1/6
File src/platform/vboot_reference/tests/run_image_verification_tests.sh (right):

http://codereview.chromium.org/1101004/diff/1/6#newcode12
src/platform/vboot_reference/tests/run_image_verification_tests.sh:12: 
Extra line

[gauravsh, 2010-03-19 23:19:37]

Submitting.

http://codereview.chromium.org/1101004/diff/1/2
File src/platform/vboot_reference/tests/common.sh (right):

http://codereview.chromium.org/1101004/diff/1/2#newcode32
src/platform/vboot_reference/tests/common.sh:32: 
On 2010/03/19 23:09:07, sosa wrote:
> Extra line

Done.

http://codereview.chromium.org/1101004/diff/1/5
File src/platform/vboot_reference/tests/gen_test_keys.sh (right):

http://codereview.chromium.org/1101004/diff/1/5#newcode26
src/platform/vboot_reference/tests/gen_test_keys.sh:26: if [ ! -d ${TESTKEY_DIR}
]
On 2010/03/19 23:09:07, sosa wrote:
> mkdir -p takes one line!
Oh yes, Done.

http://codereview.chromium.org/1101004/diff/1/6
File src/platform/vboot_reference/tests/run_image_verification_tests.sh (right):

http://codereview.chromium.org/1101004/diff/1/6#newcode12
src/platform/vboot_reference/tests/run_image_verification_tests.sh:12: 
On 2010/03/19 23:09:07, sosa wrote:
> Extra line
Done.

[sosa, 2010-03-19 23:20:35]

Sorry for taking so long!

On Fri, Mar 19, 2010 at 4:19 PM,  <gauravsh@chromium.org> wrote:
> Submitting.
>
>
> http://codereview.chromium.org/1101004/diff/1/2
> File src/platform/vboot_reference/tests/common.sh (right):
>
> http://codereview.chromium.org/1101004/diff/1/2#newcode32
> src/platform/vboot_reference/tests/common.sh:32:
> On 2010/03/19 23:09:07, sosa wrote:
>>
>> Extra line
>
> Done.
>
> http://codereview.chromium.org/1101004/diff/1/5
> File src/platform/vboot_reference/tests/gen_test_keys.sh (right):
>
> http://codereview.chromium.org/1101004/diff/1/5#newcode26
> src/platform/vboot_reference/tests/gen_test_keys.sh:26: if [ ! -d
> ${TESTKEY_DIR} ]
> On 2010/03/19 23:09:07, sosa wrote:
>>
>> mkdir -p takes one line!
>
> Oh yes, Done.
>
> http://codereview.chromium.org/1101004/diff/1/6
> File src/platform/vboot_reference/tests/run_image_verification_tests.sh
> (right):
>
> http://codereview.chromium.org/1101004/diff/1/6#newcode12
> src/platform/vboot_reference/tests/run_image_verification_tests.sh:12:
> On 2010/03/19 23:09:07, sosa wrote:
>>
>> Extra line
>
> Done.
>
> http://codereview.chromium.org/1101004
>