Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1709)

Unified Diff: sync/internal_api/public/base/ordinal.h

Issue 10989063: Changed DB to store node positions as Ordinals. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Ordinal default ctor now creates invalid Ordinals Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/base/ordinal.h
diff --git a/sync/internal_api/public/base/ordinal.h b/sync/internal_api/public/base/ordinal.h
index 91897599e782efda44c6854ee11bfbe31dabf3da..ee30e5e6a0776dcf96593c50abcaa682fffcf561 100644
--- a/sync/internal_api/public/base/ordinal.h
+++ b/sync/internal_api/public/base/ordinal.h
@@ -78,7 +78,7 @@ class Ordinal {
// may be valid or invalid.
explicit Ordinal(const std::string& bytes);
- // Creates an invalid Ordinal.
+ // Creates a valid initial Ordinal.
akalin 2012/10/05 22:40:27 revert this
vishwath 2012/10/08 20:17:49 Done.
Ordinal();
// Creates a valid initial Ordinal. This is called to create the first
@@ -234,6 +234,13 @@ Ordinal<Traits>::Ordinal(const std::string& bytes)
template <typename Traits>
Ordinal<Traits>::Ordinal() : is_valid_(false) {}
+//template <typename Traits>
akalin 2012/10/05 22:40:27 remove this
vishwath 2012/10/08 20:17:49 Done.
+//Ordinal<Traits>::Ordinal()
+// : bytes_(Traits::kMinLength, kZeroDigit),
+// is_valid_(true){
+// bytes_[0] = kMidDigit;
+//}
+
template <typename Traits>
Ordinal<Traits> Ordinal<Traits>::CreateInitialOrdinal() {
std::string bytes(Traits::kMinLength, kZeroDigit);

Powered by Google App Engine
This is Rietveld 408576698