sync/internal_api/public/base/ordinal_unittest.cc - Issue 10989063: Changed DB to store node positions as Ordinals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/ordinal_unittest.cc

Issue 10989063: Changed DB to store node positions as Ordinals. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Ordinal default ctor now creates invalid Ordinals Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base/ordinal_unittest.cc

diff --git a/sync/internal_api/public/base/ordinal_unittest.cc b/sync/internal_api/public/base/ordinal_unittest.cc

index 20a6d194edf66651fcb94afc7c2268e268113f68..4ec2e296348c22421ffe45bf4fa92952f3f5c90a 100644

--- a/sync/internal_api/public/base/ordinal_unittest.cc

+++ b/sync/internal_api/public/base/ordinal_unittest.cc

@@ -131,7 +131,7 @@ TEST(Ordinal, CreateInitialOrdinal) {

// return true if called reflexively and false otherwise.

TEST(Ordinal, EqualsOrBothInvalid) {

const TestOrdinal& valid_ordinal = TestOrdinal::CreateInitialOrdinal();

- const TestOrdinal invalid_ordinal;

+ const TestOrdinal invalid_ordinal("");

akalin 2012/10/05 22:40:27 revert

vishwath 2012/10/08 20:17:49 Done.

EXPECT_TRUE(valid_ordinal.EqualsOrBothInvalid(valid_ordinal));

EXPECT_TRUE(invalid_ordinal.EqualsOrBothInvalid(invalid_ordinal));