Forcing disabling of spelling temporarily until flag is fixed.

Forcing disabling of spelling temporarily until flag is fixed.


BUG=144863

[groby-ooo-7-16, 2012-09-28 18:53:13]

Are we guaranteed this is the first place where we query the command line? (If
so, I'll LGTM, 'cause it's needed as a hot patch, but not happy)

Otherwise, would it be better to simply comment out all places that get the flag
and hand-code the return value to false?

(Also, do we want to turn off _async_ spelling? Or should we look at
prefs::kSpellCheckUseSpellingService instead if we want to turn off spelling
service?)

[rpetterson, 2012-09-28 20:22:20]

On 2012/09/28 18:53:13, groby wrote:
> Are we guaranteed this is the first place where we query the command line? (If
> so, I'll LGTM, 'cause it's needed as a hot patch, but not happy)

Yeah, I'm not psyched about it either. This is called very early, certainly
before the only other place I see it which is in the spelling service client
itself (which isn't created until the Profile is).

> Otherwise, would it be better to simply comment out all places that get the
flag
> and hand-code the return value to false?

That is another option since it's only used in SpellingServiceClient. I was
erring on the side of overly cautious since standard spellcheck still works this
way.

> 
> (Also, do we want to turn off _async_ spelling? Or should we look at
> prefs::kSpellCheckUseSpellingService instead if we want to turn off spelling
> service?)

So, what we if just set prefs::kSpellCheckUseSpellingService to false in to
Profile constructor as a temporary fix? Because yes, I'm concerned about async
spelling as well . . . I'm going to test that in the meantime.

[rpetterson, 2012-09-28 20:25:03]

> So, what we if just set prefs::kSpellCheckUseSpellingService to false in to
> Profile constructor as a temporary fix? Because yes, I'm concerned about async
> spelling as well . . . I'm going to test that in the meantime.

Ignore that. It is set to false unless they've explicitly opted in through the
bubble . . . which, if this is changing, I suspect they're not? That was the
other reasoning behind my umbrella shutoff.