Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 10980016: Register Android's media/ and net/ JNI bindings when running DumpRenderTree. (Closed)

Created:
8 years, 2 months ago by Peter Beverloo
Modified:
8 years, 2 months ago
Reviewers:
tony, bulach
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Register Android's media/ and net/ JNI bindings when running DumpRenderTree. We only selectively loaded a single class, while we should be deferring to the component's registration function instead. BUG= TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M webkit/support/platform_support_android.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
android lgtm, but not an owner..
8 years, 2 months ago (2012-09-25 14:07:37 UTC) #1
Peter Beverloo
+tony for OWNERS A large part of the crashes can be observed in these logs: ...
8 years, 2 months ago (2012-09-25 14:08:40 UTC) #2
tony
rs LGTM. The TEST= line in the description is for QA testers. I would use ...
8 years, 2 months ago (2012-09-25 17:09:08 UTC) #3
Peter Beverloo
On 2012/09/25 17:09:08, tony wrote: > rs LGTM. > > The TEST= line in the ...
8 years, 2 months ago (2012-09-25 17:15:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/10980016/1
8 years, 2 months ago (2012-09-25 17:15:50 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 19:51:14 UTC) #6
Change committed as 158636

Powered by Google App Engine
This is Rietveld 408576698