Mac Web Intents Part 1: Show extension download progress

chrome/browser/extensions/webstore_installer.h

Index: chrome/browser/extensions/webstore_installer.h
diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h
index 1555234db7aeda274638f67ebd3788731041d3f2..a0be6cf579d6a826e316c5a36928f2271c87e093 100644
--- a/chrome/browser/extensions/webstore_installer.h
+++ b/chrome/browser/extensions/webstore_installer.h
@@ -44,11 +44,21 @@ class WebstoreInstaller :public content::NotificationObserver,
     FLAG_INLINE_INSTALL = 1 << 0
   };
 
+  enum FailureReason {
+    FAILURE_REASON_CANCELLED,
+    FAILURE_REASON_OTHER
+  };
+
   class Delegate {
    public:
+    virtual void OnExtensionDownloadStarted(const std::string& id,
+                                            content::DownloadItem* item) {}
+    virtual void OnExtensionDownloadProgress(const std::string& id,
+                                             content::DownloadItem* item) {}

[miket_OOO, 2012/10/02 21:09:52]

Don't inline these (sorry).

http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....

[sail, 2012/10/02 21:48:26]

Done.

     virtual void OnExtensionInstallSuccess(const std::string& id) = 0;
     virtual void OnExtensionInstallFailure(const std::string& id,
-                                           const std::string& error) = 0;
+                                           const std::string& error,
+                                           FailureReason reason) = 0;
 
    protected:
     virtual ~Delegate() {}
@@ -145,7 +155,7 @@ class WebstoreInstaller :public content::NotificationObserver,
 
   // Reports an install |error| to the delegate for the given extension if this
   // managed its installation. This also removes the associated PendingInstall.
-  void ReportFailure(const std::string& error);
+  void ReportFailure(const std::string& error, FailureReason reason);
 
   // Reports a successful install to the delegate for the given extension if
   // this managed its installation. This also removes the associated