Mac Web Intents Part 1: Show extension download progress

chrome/browser/extensions/webstore_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 26 matching lines @@
   WebstoreInstaller, content::BrowserThread::DeleteOnUIThread> {
  public:
   enum Flag {
     FLAG_NONE = 0,
 
     // Inline installs trigger slightly different behavior (install source
     // is different, download referrers are the item's page in the gallery).
     FLAG_INLINE_INSTALL = 1 << 0
   };
 
+  enum FailureReason {
+    FAILURE_REASON_CANCELLED,
+    FAILURE_REASON_OTHER
+  };
+
   class Delegate {
    public:
+    virtual void OnExtensionDownloadStarted(const std::string& id,
+                                            content::DownloadItem* item) {}
+    virtual void OnExtensionDownloadProgress(const std::string& id,
+                                             content::DownloadItem* item) {}

[miket_OOO, 2012/10/02 21:09:52]

Don't inline these (sorry).

http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....

[sail, 2012/10/02 21:48:26]

Done.

     virtual void OnExtensionInstallSuccess(const std::string& id) = 0;
     virtual void OnExtensionInstallFailure(const std::string& id,
-                                           const std::string& error) = 0;
+                                           const std::string& error,
+                                           FailureReason reason) = 0;
 
    protected:
     virtual ~Delegate() {}
   };
 
   // Contains information about what parts of the extension install process can
   // be skipped or modified. If one of these is present, it means that a CRX
   // download was initiated by WebstoreInstaller. The Approval instance should
   // be checked further for additional details.
   struct Approval : public base::SupportsUserData::Data {
@@ skipping 76 matching lines @@
 
   // DownloadItem::Observer implementation:
   virtual void OnDownloadUpdated(content::DownloadItem* download) OVERRIDE;
   virtual void OnDownloadDestroyed(content::DownloadItem* download) OVERRIDE;
 
   // Starts downloading the extension to |file_path|.
   void StartDownload(const FilePath& file_path);
 
   // Reports an install |error| to the delegate for the given extension if this
   // managed its installation. This also removes the associated PendingInstall.
-  void ReportFailure(const std::string& error);
+  void ReportFailure(const std::string& error, FailureReason reason);
 
   // Reports a successful install to the delegate for the given extension if
   // this managed its installation. This also removes the associated
   // PendingInstall.
   void ReportSuccess();
 
   content::NotificationRegistrar registrar_;
   Profile* profile_;
   Delegate* delegate_;
   content::NavigationController* controller_;
   std::string id_;
   // The DownloadItem is owned by the DownloadManager and is valid from when
   // OnDownloadStarted is called (with no error) until OnDownloadDestroyed().
   content::DownloadItem* download_item_;
   scoped_ptr<Approval> approval_;
   GURL download_url_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_