chrome/browser/extensions/api/webstore_private/webstore_private_api.h - Issue 10980002: Mac Web Intents Part 1: Show extension download progress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

Issue 10980002: Mac Web Intents Part 1: Show extension download progress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_util.cc ('K') | « chrome/browser/download/download_util.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | chrome/browser/extensions/webstore_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

index c69afddf361d4ba48c9ad4c41ea7651a1a408902..fde7fe8b03562290bf336451170540810f1e715f 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

@@ -158,7 +158,8 @@ class CompleteInstallFunction

// WebstoreInstaller::Delegate:

virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;

virtual void OnExtensionInstallFailure(const std::string& id,

- const std::string& error) OVERRIDE;

+ const std::string& error,

+ bool cancelled) OVERRIDE;

Nico 2012/09/25 03:07:18 prefer enums over bool parameters

Steve McKay 2012/09/25 18:56:04 +1, much more flexible and can aide readability to

sail 2012/10/02 18:57:01 Done. Changed to WebstoreInstaller::FailureReason

protected:

virtual ~CompleteInstallFunction() {}