Mac Web Intents Part 1: Show extension download progress

chrome/browser/extensions/api/webstore_private/webstore_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEBSTORE_PRIVATE_WEBSTORE_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_WEBSTORE_PRIVATE_WEBSTORE_PRIVATE_API_H_
 
 #include <string>
 
 #include "chrome/browser/extensions/bundle_installer.h"
@@ skipping 140 matching lines @@
 
 class CompleteInstallFunction
     : public AsyncExtensionFunction,
       public WebstoreInstaller::Delegate {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
 
   // WebstoreInstaller::Delegate:
   virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
   virtual void OnExtensionInstallFailure(const std::string& id,
-                                         const std::string& error) OVERRIDE;
+                                         const std::string& error,
+                                         bool cancelled) OVERRIDE;

[Nico, 2012/09/25 03:07:18]

prefer enums over bool parameters

[Steve McKay, 2012/09/25 18:56:04]

+1, much more flexible and can aide readability too.

[sail, 2012/10/02 18:57:01]

Done.
Changed to WebstoreInstaller::FailureReason

  protected:
   virtual ~CompleteInstallFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
 class GetBrowserLoginFunction : public SyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.getBrowserLogin");
@@ skipping 43 matching lines @@
 
  private:
   void CreateResult(bool webgl_allowed);
 
   scoped_refptr<GPUFeatureChecker> feature_checker_;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEBSTORE_PRIVATE_WEBSTORE_PRIVATE_API_H_